Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/shared_memory_android.cc

Issue 7701014: Upstream misc changes for android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/process_util.cc ('K') | « base/process_util.cc ('k') | base/third_party/nspr/prtime.cc » ('j') | base/third_party/nspr/prtime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/shared_memory_android.cc
diff --git a/base/shared_memory_android.cc b/base/shared_memory_android.cc
index c2f33159f0730ec41f41808062b0ece50a4d7fc9..72c3a5684455e31cf8e309f28ab4b205bfdf31ef 100644
--- a/base/shared_memory_android.cc
+++ b/base/shared_memory_android.cc
@@ -39,9 +39,9 @@ bool SharedMemory::CreateNamed(const std::string& name,
}
bool SharedMemory::Delete(const std::string& name) {
- // ashmem doesn't support name mapping
- NOTIMPLEMENTED();
- return false;
+ // Like on Windows, this is intentionally returning true as ashmem will
+ // automatically releases the resource when all FDs on it are closed.
+ return true;
}
bool SharedMemory::Open(const std::string& name, bool read_only) {
« base/process_util.cc ('K') | « base/process_util.cc ('k') | base/third_party/nspr/prtime.cc » ('j') | base/third_party/nspr/prtime.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698