Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: base/path_service_unittest.cc

Issue 7701014: Upstream misc changes for android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address the comment Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/os_compat_android.h ('k') | base/process_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/path_service.h" 5 #include "base/path_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // On the Mac this winds up using some autoreleased objects, so we need to 44 // On the Mac this winds up using some autoreleased objects, so we need to
45 // be a PlatformTest. 45 // be a PlatformTest.
46 typedef PlatformTest PathServiceTest; 46 typedef PlatformTest PathServiceTest;
47 47
48 // Test that all PathService::Get calls return a value and a true result 48 // Test that all PathService::Get calls return a value and a true result
49 // in the development environment. (This test was created because a few 49 // in the development environment. (This test was created because a few
50 // later changes to Get broke the semantics of the function and yielded the 50 // later changes to Get broke the semantics of the function and yielded the
51 // correct value while returning false.) 51 // correct value while returning false.)
52 TEST_F(PathServiceTest, Get) { 52 TEST_F(PathServiceTest, Get) {
53 for (int key = base::DIR_CURRENT; key < base::PATH_END; ++key) { 53 for (int key = base::DIR_CURRENT; key < base::PATH_END; ++key) {
54 #if defined(OS_ANDROID)
55 if (key == base::FILE_MODULE)
56 continue; // Android doesn't implement FILE_MODULE;
57 #endif
54 EXPECT_PRED1(ReturnsValidPath, key); 58 EXPECT_PRED1(ReturnsValidPath, key);
55 } 59 }
56 #if defined(OS_WIN) 60 #if defined(OS_WIN)
57 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) { 61 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) {
58 if (key == base::DIR_LOCAL_APP_DATA_LOW && 62 if (key == base::DIR_LOCAL_APP_DATA_LOW &&
59 base::win::GetVersion() < base::win::VERSION_VISTA) { 63 base::win::GetVersion() < base::win::VERSION_VISTA) {
60 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected to 64 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected to
61 // fail. 65 // fail.
62 EXPECT_TRUE(ReturnsInvalidPath(key)) << key; 66 EXPECT_TRUE(ReturnsInvalidPath(key)) << key;
63 } else { 67 } else {
64 EXPECT_TRUE(ReturnsValidPath(key)) << key; 68 EXPECT_TRUE(ReturnsValidPath(key)) << key;
65 } 69 }
66 } 70 }
67 #elif defined(OS_MACOSX) 71 #elif defined(OS_MACOSX)
68 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) { 72 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) {
69 EXPECT_PRED1(ReturnsValidPath, key); 73 EXPECT_PRED1(ReturnsValidPath, key);
70 } 74 }
71 #endif 75 #endif
72 } 76 }
OLDNEW
« no previous file with comments | « base/os_compat_android.h ('k') | base/process_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698