Issue 7701013: [ntp4] Limit the maximum bookmark tiles that will display at once, for now.

Issue 7701013: [ntp4] Limit the maximum bookmark tiles that will display at once, for now. (Closed)

Created:
9 years, 4 months ago by csilv

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Limit the maximum bookmark tiles that will display at once, for now. BUG=93049 TEST=View bookmarks folder with large number of bookmarks, should quickly display the first 60 items. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98295

Patch Set 1 #

Patch Set 2 : cosmetic tweak #

Total comments: 5

Patch Set 3 : code review changes; rebase #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/bookmarks_page.css	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/bookmarks_page.js	View	1 2	4 chunks	+34 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resources.grd#newcode8301 chrome/app/generated_resources.grd:8301: View all bookmarks for this folder I'm open to ...

9 years, 4 months ago (2011-08-23 22:47:43 UTC) #1

Evan Stade

lgtm http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resources.grd#newcode8301 chrome/app/generated_resources.grd:8301: View all bookmarks for this folder simply "More..." ...

9 years, 4 months ago (2011-08-25 01:46:24 UTC) #3

csilv

9 years, 4 months ago (2011-08-25 17:41:56 UTC) #4

http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7701013/diff/3001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:8301: View all bookmarks for this folder
On 2011/08/25 01:46:24, Evan Stade wrote:
> simply "More..."

Done.

http://codereview.chromium.org/7701013/diff/3001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/bookmarks_page.js (right):

http://codereview.chromium.org/7701013/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/bookmarks_page.js:24: var MAX_BOOKMARK_TILES = 60;
On 2011/08/25 01:46:24, Evan Stade wrote:
> I'd do 18

Done.

Expand Messages | Collapse Messages