Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issue 7701010: Fix file uploads in chromedriver. It should not be assumed that multiple file (Closed)

Created:
9 years, 4 months ago by kkania
Modified:
9 years, 3 months ago
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix file uploads in chromedriver. It should not be assumed that multiple file names are separate elements in the input array. BUG=92911, 93909 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98796

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M chrome/test/webdriver/commands/webelement_commands.cc View 2 chunks +29 lines, -25 lines 2 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kkania
9 years, 4 months ago (2011-08-23 22:03:00 UTC) #1
Huyen
http://codereview.chromium.org/7701010/diff/3001/chrome/test/webdriver/commands/webelement_commands.cc File chrome/test/webdriver/commands/webelement_commands.cc (right): http://codereview.chromium.org/7701010/diff/3001/chrome/test/webdriver/commands/webelement_commands.cc#newcode553 chrome/test/webdriver/commands/webelement_commands.cc:553: base::SplitString(paths_string, '\n', &paths); why not just directly go from ...
9 years, 4 months ago (2011-08-23 22:10:44 UTC) #2
kkania
http://codereview.chromium.org/7701010/diff/3001/chrome/test/webdriver/commands/webelement_commands.cc File chrome/test/webdriver/commands/webelement_commands.cc (right): http://codereview.chromium.org/7701010/diff/3001/chrome/test/webdriver/commands/webelement_commands.cc#newcode553 chrome/test/webdriver/commands/webelement_commands.cc:553: base::SplitString(paths_string, '\n', &paths); not sure what you mean: The ...
9 years, 4 months ago (2011-08-25 20:16:58 UTC) #3
kkania
ping
9 years, 4 months ago (2011-08-26 17:41:19 UTC) #4
Huyen
On 2011/08/26 17:41:19, kkania wrote: > ping lgtm
9 years, 4 months ago (2011-08-26 18:27:04 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-08-30 09:35:30 UTC) #6
Change committed as 98796

Powered by Google App Engine
This is Rietveld 408576698