Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 7697017: Prepare push to trunk. Working version now 3.5.8. (Closed)

Created:
9 years, 4 months ago by rossberg
Modified:
9 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Working version now 3.5.8. Committed: http://code.google.com/p/v8/source/detail?r=8980

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rossberg
9 years, 4 months ago (2011-08-22 10:35:27 UTC) #1
Jakob Kummerow
9 years, 4 months ago (2011-08-22 10:39:09 UTC) #2
LGTM

http://codereview.chromium.org/7697017/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7697017/diff/1/ChangeLog#newcode3
ChangeLog:3: GYP fixes: -Werror, snapshot.log, want_separate_host_toolset
detection.
I'm not sure this is important enough to be mentioned.

Powered by Google App Engine
This is Rietveld 408576698