Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 7697006: Enabled typed URL syncing by default. (Closed)

Created:
9 years, 4 months ago by Andrew T Wilson (Slow)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Enabled typed URL syncing by default. BUG=none TEST=Bring up sync setup dialog, see that Omnibox History is available as a data type, no Omnibox History flag in about:flags. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97953

Patch Set 1 #

Patch Set 2 : Updated unit tests to reflect new enabled type (typed urls)" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -26 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrew T Wilson (Slow)
Please take a look. While I was updating the command line flags, I noticed that ...
9 years, 4 months ago (2011-08-19 18:35:12 UTC) #1
akalin
LGTM
9 years, 4 months ago (2011-08-20 05:18:23 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-24 00:19:49 UTC) #3
Change committed as 97953

Powered by Google App Engine
This is Rietveld 408576698