Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: content/plugin/npobject_stub.h

Issue 7696016: Remove the window script object tear-down special-case. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/plugin/npobject_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/npobject_stub.h
diff --git a/content/plugin/npobject_stub.h b/content/plugin/npobject_stub.h
index 3584cfe4640ff5f3607711e76977807160061f13..d48fa09aa450069bbfc60b2438ac5bc6ab2d5dca 100644
--- a/content/plugin/npobject_stub.h
+++ b/content/plugin/npobject_stub.h
@@ -38,13 +38,11 @@ class NPObjectStub : public IPC::Channel::Listener,
const GURL& page_url);
virtual ~NPObjectStub();
- // Cause the stub to ignore any further IPC messages, and to tear itself down
- // the next time control returns to the message loop.
- // The NPObject will be released only if |release_npobject| is true.
- // This is used for the window script object stub in the renderer, which is
- // freed with NPN_DeallocateObject to avoid leaks, and so we must not try to
- // release it.
- void DeleteSoon(bool release_npobject);
+ // Schedules tear-down of this stub. The underlying NPObject reference is
+ // released, and further invokations form the IPC channel will fail once this
+ // call has returned. Deletion of the stub is deferred to the main loop, in
+ // case it is touched as the stack unwinds.
+ void DeleteSoon();
// IPC::Message::Sender implementation:
virtual bool Send(IPC::Message* msg);
« no previous file with comments | « no previous file | content/plugin/npobject_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698