ninja: land generator for ninja files

test/actions/gyptest-all.py

 #!/usr/bin/env python
 
 # Copyright (c) 2009 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Verifies simple actions when using an explicit build target of 'all'.
 """
 
 import glob
 import os
 import TestGyp
 
 test = TestGyp.TestGyp(workdir='workarea_all')
 
 test.run_gyp('actions.gyp', chdir='src')
 
 test.relocate('src', 'relocate/src')
 
-# Test that an "always run" action increases a counter on multiple invocations,
-# and that a dependent action updates in step.
-test.build('actions.gyp', test.ALL, chdir='relocate/src')
-test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '1')
-test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '1')
-test.build('actions.gyp', test.ALL, chdir='relocate/src')
-test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '2')
-test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '2')
+# Some gyp files use an action that mentions an output but never writes it
+# as a means to making something run on every build.  That makes some pretty

[Nico, 2011/08/19 18:21:25]

Remove 2nd sentence.

[Evan Martin, 2011/08/19 18:37:13]

Hm, do you not like the wording, or what it is saying?  It is the note I wrote
to myself about why it is hard to make this test work (I spent some time
trying).

[Nico, 2011/08/19 22:45:10]

It didn't add any signal to the comment for me, just made it longer. If it helps
you, keep it.

+# far-reaching assumptions about how build systems work and doesn't work with
+# ninja.  TODO(evan): figure out how to work always-run actions in to ninja.
+if test.format != 'ninja':
+  # Test that an "always run" action increases a counter on multiple invocations,
+  # and that a dependent action updates in step.
+  test.build('actions.gyp', test.ALL, chdir='relocate/src')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '1')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '1')
+  test.build('actions.gyp', test.ALL, chdir='relocate/src')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '2')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '2')
 
-# The "always run" action only counts to 2, but the dependent target will count
-# forever if it's allowed to run. This verifies that the dependent target only
-# runs when the "always run" action generates new output, not just because the
-# "always run" ran.
-test.build('actions.gyp', test.ALL, chdir='relocate/src')
-test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '2')
-test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '2')
+  # The "always run" action only counts to 2, but the dependent target will count
+  # forever if it's allowed to run. This verifies that the dependent target only
+  # runs when the "always run" action generates new output, not just because the
+  # "always run" ran.
+  test.build('actions.gyp', test.ALL, chdir='relocate/src')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter.txt', '2')
+  test.must_match('relocate/src/subdir1/actions-out/action-counter_2.txt', '2')
 
 expect = """\
 Hello from program.c
 Hello from make-prog1.py
 Hello from make-prog2.py
 """
 
 if test.format == 'xcode':
   chdir = 'relocate/src/subdir1'
 else:
@@ skipping 38 matching lines @@
 # previous tests deleted.  Confirm this execution did NOT run the ALL
 # target which would mess up our dep tests.
 clean_dep_files()
 test.build('actions.gyp', 'action_with_dependencies_321', chdir='relocate/src',
            arguments=arguments)
 test.must_exist('relocate/src/deps_all_done_first_321.txt')
 test.must_not_exist('relocate/src/deps_all_done_first_123.txt')
 
 
 test.pass_test()