Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 7695003: Fix issue with permissions extension API event listeners. (Closed)

Created:
9 years, 4 months ago by jstritar
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix issue with permissions extension API event listeners. Make sure the renderers receive the changes in permissions before triggering the permissions.onAdded and permission.onRemoved extension events. BUG=48119 TEST=*OptionalPermission* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M chrome/browser/extensions/extension_permissions_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/permissions/optional/background.html View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jstritar
9 years, 4 months ago (2011-08-19 18:57:24 UTC) #1
Mihai Parparita -not on Chrome
LGTM
9 years, 4 months ago (2011-08-19 19:28:52 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-22 17:41:56 UTC) #3
Change committed as 97679

Powered by Google App Engine
This is Rietveld 408576698