chrome/browser/ui/panels/panel_browser_window_cocoa.h - Issue 7694014: Reland: Implement correct Panel closing sequence for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.h

Issue 7694014: Reland: Implement correct Panel closing sequence for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed random result of CreateClose unittest caused by using a freed object. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_browser_window_cocoa.h

diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.h b/chrome/browser/ui/panels/panel_browser_window_cocoa.h

index 2f88a70dc3926c6b058b602419bb6c0478fea564..eb0c19e4f7424409ce698257a97c15cb86f62890 100644

--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.h

+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.h

@@ -56,6 +56,11 @@ class PanelBrowserWindowCocoa : public NativePanel {

Panel* panel() { return panel_.get(); }

Browser* browser() const { return browser_.get(); }

+ // Callback from PanelWindowControllerCocoa that native window was actually

+ // closed. The window may not close right away because of onbeforeunload

+ // handlers.

+ void didCloseNativeWindow();

private:

friend class PanelBrowserWindowCocoaTest;

FRIEND_TEST_ALL_PREFIXES(PanelBrowserWindowCocoaTest, CreateClose);