Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 7694014: Reland: Implement correct Panel closing sequence for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 450eee5cd5c74ed7f53f57809f5fffd22a15de81..8c0cf87d9aa5501e7bc4e006d3743d9aa27d19af 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -87,7 +87,13 @@ void Panel::SetBounds(const gfx::Rect& bounds) {
// close on the first attempt.
void Panel::Close() {
native_panel_->ClosePanel();
+
+// TODO(dimich): we need to only remove the panel when and if it actually
jennb 2011/08/19 21:46:12 Even if the panel isn't closing immediately, can't
Dmitry Titov 2011/08/22 18:34:56 See comment at the top.
+// closes. It is now only implemented on Mac (unless it's synchronous on other
+// platforms).
+#if !defined(OS_MACOSX)
manager()->Remove(this);
+#endif
}
void Panel::Activate() {

Powered by Google App Engine
This is Rietveld 408576698