Reland: Implement correct Panel closing sequence for Mac.

chrome/browser/ui/panels/panel_browser_window_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
 
 #include "base/logging.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
 #include "chrome/browser/ui/panels/panel.h"
+#include "chrome/browser/ui/panels/panel_manager.h"
 #import "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 
 namespace {
 
 // Use this instead of 0 for minimum size of a window when doing opening and
 // closing animations, since OSX window manager does not like 0-sized windows
 // (according to avi@).
 const int kMinimumWindowSize = 1;
 
 // TODO(dcheng): Move elsewhere so BrowserWindowCocoa can use them too.
@@ skipping 74 matching lines @@
                                                          int mouse_y) const {
   NOTIMPLEMENTED();
   return false;
 }
 
 void PanelBrowserWindowCocoa::ClosePanel() {
   if (isClosed())
       return;
 
   NSWindow* window = [controller_ window];
-  NSRect frame = [window frame];
-  frame.size.height = kMinimumWindowSize;
-  // TODO(dimich): make this async. Currently, multiple panels will serially
-  // (and annoyingly) close when user exits Chrome.
-  [window setFrame:frame display:YES animate:YES];
-  browser_->OnWindowClosing();
-  DestroyPanelBrowser();  // not immediately, though.
+  [window performClose:controller_];

[jennb, 2011/08/19 21:46:12]

I prefer to animate the window offscreen here, then call performClose.

[Dmitry Titov, 2011/08/22 18:34:56]

See comment at the top.

 }
 
 void PanelBrowserWindowCocoa::ActivatePanel() {
   NOTIMPLEMENTED();
 }
 
 void PanelBrowserWindowCocoa::DeactivatePanel() {
   NOTIMPLEMENTED();
 }
 
@@ skipping 35 matching lines @@
   NOTIMPLEMENTED();
   return false;
 }
 
 Browser* PanelBrowserWindowCocoa::GetPanelBrowser() const {
   return browser();
 }
 
 void PanelBrowserWindowCocoa::DestroyPanelBrowser() {
   [controller_ close];
+}
+
+void PanelBrowserWindowCocoa::didCloseNativeWindow() {
+  DCHECK(!isClosed());
+  panel_->manager()->Remove(panel_.get());
   controller_ = NULL;
 }
-
 // NativePanelTesting implementation.
 
 // static
 NativePanelTesting* NativePanelTesting::Create(NativePanel* native_panel) {
   NOTIMPLEMENTED();
   return NULL;
 }