chrome/test/data/prerender/prerender_visibility_quick.html - Issue 7693029: Deflake PrerenderExcessiveMemory, fix race

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_visibility_quick.html

Issue 7693029: Deflake PrerenderExcessiveMemory, fix race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove extra logging, update comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <!--

	3 This test checks the visibility API when a prerendered page is displayed

	4 before the page has finished loading.

	5

	6 TODO(mmenke): Currently, we get get extra events when a page is shown on
	dominich 2011/08/25 21:18:04 Is this due to the code that forcibly unhides the Is this due to the code that forcibly unhides the renderview twice on Windows? Is that still there and needed after switching to Tabs? mmenke 2011/08/25 21:36:53 That code no longer seems to exist, or at least I Show quoted text On 2011/08/25 21:18:04, dominich wrote: > Is this due to the code that forcibly unhides the renderview twice on Windows? > Is that still there and needed after switching to Tabs? That code no longer seems to exist, or at least I can't find it. We still do have the extra transition, however. Looking into it is on my TODO list, but not very high on it.
	7 Windows. Make this check for extra events once that's fixed.

	8 -->

	9 <head>

	10 <title>Prerender Visibility Quick Switch</title>

	11

	12 <script>

	13 // Checks that the the current state is visible. Due to expected races between

	14 // loading the page and switching to the tab, it's possible for the page to

	15 // start out with visibility 'prerender', 'hidden', or 'visible'.

	16 function DidDisplayPass() {

	17 return !document.webkitHidden &&

	18 'visible' == document.webkitVisibilityState;

	19 }

	20 </script>

	21

	22 </head>

	23 <body></body>

	24 </html>

OLD	NEW