chrome/test/data/prerender/prerender_visibility_hidden_quick.html - Issue 7693029: Deflake PrerenderExcessiveMemory, fix race

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_visibility_hidden_quick.html

Issue 7693029: Deflake PrerenderExcessiveMemory, fix race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove extra logging, update comments Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/prerender/prerender_contents.cc ('k') | chrome/test/data/prerender/prerender_visibility_quick.html » ('j') | chrome/test/data/prerender/prerender_visibility_quick.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 <html>

	2 <!--

	3 This test checks the visibility API when a prerendered page is visited without

	4 being displayed, before the page has finished loading.

	5 -->

	6 <head>

	7 <title>Prerender Visibility Hidden Quick Switch</title>

	8

	9 <script>

	10 // Checks visibility state while the page is still loading.

	11 var lastState = document.webkitVisibilityState;

	12 var loadingStatePassed = document.webkitHidden &&

	13 (lastState == 'prerender' \|\| lastState == 'hidden');
	dominich 2011/08/25 21:18:04 it might be more future-proof to check that lastSt it might be more future-proof to check that lastState !== 'visible' mmenke 2011/08/25 21:36:53 Done. Still only allow at most one transition fro Show quoted text On 2011/08/25 21:18:04, dominich wrote: > it might be more future-proof to check that lastState !== 'visible' Done. Still only allow at most one transition from non-hidden to hidden.
	14 var unexpectedStateChange = false;

	15

	16 function onVisibilityChange(event) {

	17 if (lastState != 'prerender' \|\|

	18 document.webkitVisibilityState != 'hidden') {

	19 unexpectedStateChange = true;

	20 return;

	21 }

	22 lastState = document.webkitVisibilityState;

	23 }

	24

	25 document.addEventListener('webkitvisibilitychange',

	26 onVisibilityChange,

	27 false);

	28

	29 // Checks that either the first visibility state was 'prerender' and there

	30 // was one and only one visibility change event to 'hidden', or visibility

	31 // was always 'hidden'.

	32 function DidDisplayPass() {

	33 return loadingStatePassed &&

	34 !unexpectedStateChange &&

	35 'hidden' == document.webkitVisibilityState &&

	36 document.webkitHidden;

	37 }

	38 </script>

	39

	40 </head>

	41 <body></body>

	42 </html>

OLD	NEW