Issue 7693004: Added tracking of time spent waiting on extensions to the webRequest API.

Issue 7693004: Added tracking of time spent waiting on extensions to the webRequest API. (Closed)

Created:
9 years, 4 months ago by Matt Perry

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, battre

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Added tracking of time spent waiting on extensions to the webRequest API. This is part 1 of adding blame to extensions. We're just collecting the data right now, not actually using the data to warn the user. BUG=82618 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97826

Patch Set 1 #

Patch Set 2 : updated sln #

Total comments: 2

Patch Set 3 : compile #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+374 lines, -7 lines)			Patch
M	chrome/browser/extensions/extension_webrequest_api.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api.cc	View	1	11 chunks	+32 lines, -7 lines	0 comments	Download
A	chrome/browser/extensions/extension_webrequest_time_tracker.h	View	1 2	1 chunk	+95 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_webrequest_time_tracker.cc	View	1 2	1 chunk	+154 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_webrequest_time_tracker_unittest.cc	View		1 chunk	+84 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

battre

LGTM, note the compiler failure on Mac though. http://codereview.chromium.org/7693004/diff/2001/chrome/browser/extensions/extension_webrequest_time_tracker.cc File chrome/browser/extensions/extension_webrequest_time_tracker.cc (right): http://codereview.chromium.org/7693004/diff/2001/chrome/browser/extensions/extension_webrequest_time_tracker.cc#newcode135 chrome/browser/extensions/extension_webrequest_time_tracker.cc:135: // ...

9 years, 4 months ago (2011-08-22 16:23:47 UTC) #2

Change committed as 97826

Expand Messages | Collapse Messages