Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 7692020: Added forgotten V8EXPORT attributes for v8::Array::CheckCast and v8::Number::CheckCast. (Closed)

Created:
9 years, 4 months ago by Yang
Modified:
9 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Added forgotten V8EXPORT attributes for v8::Array::CheckCast and v8::Number::CheckCast. BUG=v8:1618 Committed: http://code.google.com/p/v8/source/detail?r=8986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Fixed a really old regression in the V8 header at r5017. http://code.google.com/p/v8/source/diff?spec=svn5017&r=5017&format=side&path=/trunk/include/v8.h&old_path=/trunk/include/v8.h&old=4924 When moving the ...
9 years, 4 months ago (2011-08-22 12:56:17 UTC) #1
Jakob Kummerow
9 years, 4 months ago (2011-08-22 13:00:06 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698