Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 7692006: IndexedDB API cleanup. (Closed)

Created:
9 years, 4 months ago by adamk
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, hans
Visibility:
Public.

Description

IndexedDB API cleanup. Fix Chromium impls and calls to WebIDB* interfaces to match current WebKit implementation. No change in behavior, just fewer wrapped function calls. R=dgrogan@chromium.org,darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97687

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-templatize two IndexedDBCallbacks specializations #

Patch Set 3 : Copyright presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -113 lines) Patch
M content/browser/in_process_webkit/indexed_db_callbacks.h View 1 2 chunks +11 lines, -42 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M content/common/indexed_db_messages.h View 3 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/indexed_db_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/indexed_db_dispatcher.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/renderer_webidbcursor_impl.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/renderer_webidbcursor_impl.cc View 1 2 3 chunks +6 lines, -13 lines 0 comments Download
M content/renderer/renderer_webidbdatabase_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_webidbdatabase_impl.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
9 years, 4 months ago (2011-08-19 21:03:56 UTC) #1
dgrogan
LGTM http://codereview.chromium.org/7692006/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h File content/browser/in_process_webkit/indexed_db_callbacks.h (right): http://codereview.chromium.org/7692006/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h#newcode23 content/browser/in_process_webkit/indexed_db_callbacks.h:23: template <class Type> struct WebIDBToMsgHelper { }; Can ...
9 years, 4 months ago (2011-08-19 21:30:52 UTC) #2
adamk
http://codereview.chromium.org/7692006/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h File content/browser/in_process_webkit/indexed_db_callbacks.h (right): http://codereview.chromium.org/7692006/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h#newcode23 content/browser/in_process_webkit/indexed_db_callbacks.h:23: template <class Type> struct WebIDBToMsgHelper { }; On 2011/08/19 ...
9 years, 4 months ago (2011-08-19 22:24:24 UTC) #3
dgrogan
LGTM Thanks for the cleanup.
9 years, 4 months ago (2011-08-19 22:48:18 UTC) #4
adamk
Thanks, David. Still need OWNER approval for content/renderer/, adding jam & brettw.
9 years, 4 months ago (2011-08-20 01:05:35 UTC) #5
brettw
9 years, 4 months ago (2011-08-21 15:57:54 UTC) #6
LGTM rubberstamp, please only add one person for owners review rather than
spamming everybody.

Powered by Google App Engine
This is Rietveld 408576698