Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 7692003: Revert 97482 - Apps/Extensions Sync refactoring -- delete most of the old glue, implement new syn... (Closed)

Created:
9 years, 4 months ago by Ben Olmstead
Modified:
9 years, 4 months ago
Reviewers:
Ben Olmstead
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Revert 97482 - Apps/Extensions Sync refactoring -- delete most of the old glue, implement new sync API. This should maintain current behavior; there are still a number of edge cases around sync + network issues/changing extension versions/etc. that are not fixed by this change. Reviewers: akalin: everything asargent: sanity check around ExtensionService/Extension/ExtensionSyncData BUG=83983 TEST=sync tests pass, browser tests pass, manually adding/removing extensions/apps works. Review URL: http://codereview.chromium.org/7564037 TBR=bolms@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -938 lines) Patch
M chrome/browser/extensions/extension_service.h View 7 chunks +43 lines, -59 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 12 chunks +46 lines, -248 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 10 chunks +113 lines, -204 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.h View 1 chunk +14 lines, -41 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +13 lines, -109 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +63 lines, -68 lines 0 comments Download
M chrome/browser/extensions/test_extension_service.h View 1 chunk +8 lines, -10 lines 0 comments Download
M chrome/browser/extensions/test_extension_service.cc View 1 chunk +10 lines, -16 lines 0 comments Download
A + chrome/browser/sync/glue/app_change_processor.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/app_change_processor.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/app_model_associator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/app_model_associator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_change_processor.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_change_processor.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_model_associator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_model_associator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_sync.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_sync.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_sync_traits.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_sync_traits.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/extension_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 6 chunks +24 lines, -17 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +1 line, -47 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Olmstead
9 years, 4 months ago (2011-08-19 18:14:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698