Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 7690006: Revert 97446 - Modifying prefetch to account for multi-profile. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 4 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Revert 97446 - Modifying prefetch to account for multi-profile. Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937 TEST=passes existing Review URL: http://codereview.chromium.org/7467012 TBR=rlp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -1134 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/io_thread.cc View 6 chunks +99 lines, -0 lines 0 comments Download
M chrome/browser/net/connect_interceptor.h View 3 chunks +11 lines, -19 lines 0 comments Download
M chrome/browser/net/connect_interceptor.cc View 7 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/net/net_pref_observer.h View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/net/net_pref_observer.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/net/predictor.h View 10 chunks +40 lines, -206 lines 0 comments Download
M chrome/browser/net/predictor.cc View 12 chunks +240 lines, -682 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 19 chunks +109 lines, -82 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 6 chunks +3 lines, -19 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 6 chunks +8 lines, -27 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
9 years, 4 months ago (2011-08-19 15:43:52 UTC) #1
Avi (use Gerrit)
9 years, 4 months ago (2011-08-19 15:44:20 UTC) #2
This appears to make all the CF bots crash in chrome_frame_net_tests.

Powered by Google App Engine
This is Rietveld 408576698