Don't do Instant previews of chrome://crash

Don't do Instant previews of chrome://crash

This also works for about:crash, which is normalized to chrome://crash/ by the time this function is reached.

BUG=92721
TEST=Enable instant, don't restrict to search only, type chrome://crash in omnibox without pressing enter, tab should not be loaded and crashed.

Also, interactive_ui_tests --gtest_filter=*CrashUrlCancelsInstant


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97561

[cbentzel, 2011-08-19 14:23:40]

Is there an easy way to do an instant_browsertest which checks for user text of
"foo" but the AutocompleteMatch.destination_url is "chrome://crashes"?

[sky, 2011-08-19 15:32:13]

Why should we restrict instant to only http/https?

[cbentzel, 2011-08-19 15:38:27]

Basically, in the crash case [top renderer crasher right now]
chrome://crash is being loaded via instant.

I thought a reasonable approach was to whitelist to http/https only.

If we just want to blacklist the chrome://crash URL or the chrome
scheme that's fine with me.

On Fri, Aug 19, 2011 at 11:32 AM,  <sky@chromium.org> wrote:
> Why should we restrict instant to only http/https?
>
> http://codereview.chromium.org/7689003/
>

[sky, 2011-08-19 15:45:24]

I know I type in chrome://settings and would be annoyed if that didn't
work with instant. Similarly file urls should be fine to load.
Blacklisting chrome://crash seems like the way to go.

  -Scott

On Fri, Aug 19, 2011 at 8:38 AM, Chris Bentzel <cbentzel@chromium.org> wrote:
> Basically, in the crash case [top renderer crasher right now]
> chrome://crash is being loaded via instant.
>
> I thought a reasonable approach was to whitelist to http/https only.
>
> If we just want to blacklist the chrome://crash URL or the chrome
> scheme that's fine with me.
>
> On Fri, Aug 19, 2011 at 11:32 AM,  <sky@chromium.org> wrote:
>> Why should we restrict instant to only http/https?
>>
>> http://codereview.chromium.org/7689003/
>>
>

[cbentzel, 2011-08-19 15:48:09]

SGTM, I'll go that route instead.

On Fri, Aug 19, 2011 at 11:45 AM, Scott Violet <sky@chromium.org> wrote:
> I know I type in chrome://settings and would be annoyed if that didn't
> work with instant. Similarly file urls should be fine to load.
> Blacklisting chrome://crash seems like the way to go.
>
>  -Scott
>
> On Fri, Aug 19, 2011 at 8:38 AM, Chris Bentzel <cbentzel@chromium.org> wrote:
>> Basically, in the crash case [top renderer crasher right now]
>> chrome://crash is being loaded via instant.
>>
>> I thought a reasonable approach was to whitelist to http/https only.
>>
>> If we just want to blacklist the chrome://crash URL or the chrome
>> scheme that's fine with me.
>>
>> On Fri, Aug 19, 2011 at 11:32 AM,  <sky@chromium.org> wrote:
>>> Why should we restrict instant to only http/https?
>>>
>>> http://codereview.chromium.org/7689003/
>>>
>>
>

[cbentzel, 2011-08-19 16:29:51]

The latest version restricts to chrome://crash/, and any URL that gets rewritten
to that such as about:crash

[sreeram, 2011-08-19 16:36:46]

On 2011/08/19 16:29:51, cbentzel wrote:
> The latest version restricts to chrome://crash/, and any URL that gets
rewritten
> to that such as about:crash

How about other crash URLs, such as chrome://kill, chrome://hang, etc? If the
idea is that "crash" is a prefix of "crashes", whereas "kill" is not a prefix of
any other chrome:// URL, then how about if I type "chrome://h" and it
autocompletes to "hang" (and previews it), whereas I really wanted to type
"history" or "histograms"?

[sky, 2011-08-19 16:38:41]

LGTM

[cbentzel, 2011-08-19 16:46:54]

Maybe this blacklist on chrome://about/ would make sense

chrome://crash
chrome://kill
chrome://hang
chrome://shorthang
chrome://gpuclean
chrome://gpucrash
chrome://gpuhang

On Fri, Aug 19, 2011 at 12:38 PM,  <sky@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/7689003/
>

[sky, 2011-08-19 17:01:10]

SGTM

On Fri, Aug 19, 2011 at 9:46 AM, Chris Bentzel <cbentzel@chromium.org> wrote:
> Maybe this blacklist on chrome://about/ would make sense
>
> chrome://crash
> chrome://kill
> chrome://hang
> chrome://shorthang
> chrome://gpuclean
> chrome://gpucrash
> chrome://gpuhang
>
> On Fri, Aug 19, 2011 at 12:38 PM,  <sky@chromium.org> wrote:
>> LGTM
>>
>> http://codereview.chromium.org/7689003/
>>
>

[cbentzel, 2011-08-19 17:55:17]

Newest version has a more general blacklist of URLs.

[sreeram, 2011-08-19 18:57:51]

On 2011/08/19 17:55:17, cbentzel wrote:
> Newest version has a more general blacklist of URLs.

LGTM

[sky, 2011-08-19 19:26:13]

LGTM

[commit-bot: I haz the power, 2011-08-20 05:48:17]

Change committed as 97561