Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 7687005: Create ppapi_proxy.dll. (Closed)

Created:
9 years, 4 months ago by darin (slow to review)
Modified:
9 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Create ppapi_proxy.dll and ppapi_shared.dll. This involves introducing the following macros: PPAPI_PROXY_EXPORT - for symbols exported from ppapi/proxy PPAPI_SHARED_EXPORT - for symbols exported from ppapi/shared_impl PPAPI_THUNK_EXPORT - for symbols exported from ppapi/thunk NOTE: shared_impl and thunk are still linked together, but I thought it was cleaner to give thunk its own macro. R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98508

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -133 lines) Patch
M ppapi/ppapi_proxy.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +5 lines, -10 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
A ppapi/proxy/ppapi_proxy_export.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_module.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_flash_menu.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/serialized_structs.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/serialized_var.h View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +10 lines, -8 lines 0 comments Download
M ppapi/shared_impl/audio_config_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/shared_impl/char_set_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/crypto_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/file_ref_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/font_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/function_group_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/shared_impl/graphics_3d_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/host_resource.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/id_assignment.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/image_data_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/input_event_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/shared_impl/instance_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/opengles2_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_preferences.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
A ppapi/shared_impl/ppapi_shared_export.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/resource.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/resource_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/scoped_pp_resource.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/time_conversion.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -5 lines 0 comments Download
M ppapi/shared_impl/tracker_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/url_request_info_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -4 lines 0 comments Download
M ppapi/shared_impl/url_util_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/var.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +3 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/video_decoder_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/webkit_forwarding.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +4 lines, -3 lines 0 comments Download
A ppapi/thunk/ppapi_thunk_export.h View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_audio_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_audio_config_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_file_ref_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_graphics_2d_thunk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_image_data_thunk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_image_data_trusted_thunk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_input_event_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_url_request_info_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/thunk/thunk.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +57 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
This depends on: http://codereview.chromium.org/7768001/ Even though that hasn't landed yet, I think this is ready ...
9 years, 4 months ago (2011-08-26 20:02:46 UTC) #1
brettw
9 years, 4 months ago (2011-08-26 20:34:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698