Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 7686018: Fix a bug in the TTS extension API where the getVoices function wouldn't... (Closed)

Created:
9 years, 4 months ago by dmazzoni
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix a bug in the TTS extension API where the getVoices function wouldn't return a native voice if no other extension API functions had been called, due to accessing a variable that's supposed to be initialized on demand. BUG=93642 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/extensions/extension_tts_api_controller.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dmazzoni
9 years, 4 months ago (2011-08-21 17:03:49 UTC) #1
Ben Olmstead
LGTM
9 years, 4 months ago (2011-08-22 17:53:59 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-22 20:59:31 UTC) #3
Change committed as 97730

Powered by Google App Engine
This is Rietveld 408576698