Fix crash when allocation of very large HTML canvas fails.

skia/ext/platform_canvas.cc

Index: skia/ext/platform_canvas.cc
===================================================================
--- skia/ext/platform_canvas.cc	(revision 97133)
+++ skia/ext/platform_canvas.cc	(working copy)
@@ -34,6 +34,15 @@
   return new PlatformCanvas(width, height, is_opaque);
 }
 
+SkCanvas* TryCreateBitmapCanvas(int width, int height, bool is_opaque) {

[alokp, 2011/08/19 15:34:39]

Couldn't you change the existing function to return NULL?

[junov1, 2011/08/19 15:50:25]

There are many places that currently call CreateBitmapCanvas and require it to
succeed (no graceful failure path).  The way in which CreateBitmapCanvas crashes
is actually very useful because it provides some diagnostics (see
CrashForBitmapAllocationFailure in platform_canvas_win.cc).

+  PlatformCanvas* canvas = new PlatformCanvas();
+  if (!canvas->initialize(width, height, is_opaque)) {
+    delete canvas;
+    canvas = NULL;
+  }
+  return canvas;
+}
+
 SkDevice* GetTopDevice(const SkCanvas& canvas) {
   SkCanvas::LayerIter iter(const_cast<SkCanvas*>(&canvas), false);
   return iter.device();