Fix variable names and comments in RandGenerator.

base/rand_util.h

Index: base/rand_util.h
diff --git a/base/rand_util.h b/base/rand_util.h
index c98cb4513efc46332b672040324fdaf85ab886bc..afed0913526e1b638a0ae6fa5e53f851c9d81da1 100644
--- a/base/rand_util.h
+++ b/base/rand_util.h
@@ -19,12 +19,12 @@ BASE_EXPORT uint64 RandUint64();
 // Returns a random number between min and max (inclusive). Thread-safe.
 BASE_EXPORT int RandInt(int min, int max);
 
-// Returns a random number in range [0, max).  Thread-safe.
+// Returns a random number in range [0, n).  Thread-safe.
 //
 // Note that this can be used as an adapter for std::random_shuffle():
 // Given a pre-populated |std::vector<int> myvector|, shuffle it as
 //   std::random_shuffle(myvector.begin(), myvector.end(), base::RandGenerator);
-BASE_EXPORT uint64 RandGenerator(uint64 max);
+BASE_EXPORT uint64 RandGenerator(uint64 n);

[Mark Mentovai, 2011/08/23 17:01:33]

Why did you need to rename this? It was a little more self-documenting as “max.”

[Denis Lagno, 2011/08/24 12:58:28]

I consider it being misnomer.
There is long tradition of calling maximum something that can be reached.  So
RandGenerator(max) is expected to generate numbers up to (and including) |max|
That is not the case: maximum of generated numbers for this function is (max-1)
not max.

I changed it to more suitable |range|

 
 // Returns a random double in range [0, 1). Thread-safe.
 BASE_EXPORT double RandDouble();