Fix variable names and comments in RandGenerator.

Fix variable names and comments in RandGenerator.

(No semantic change intended).

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98098

[Denis Lagno, 2011-08-23 12:49:44]

please take a look

[Mark Mentovai, 2011-08-23 17:01:33]

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc
File base/rand_util.cc (right):

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc#newcode47
base/rand_util.cc:47: DCHECK(n);
The DCHECK_GT was a bit more expressive. Why did you change it?

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc#newcode48
base/rand_util.cc:48: // We must discard random results above or equal this
number, as they would
Use correct English.

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.h
File base/rand_util.h (right):

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.h#newcode27
base/rand_util.h:27: BASE_EXPORT uint64 RandGenerator(uint64 n);
Why did you need to rename this? It was a little more self-documenting as “max.”

[Denis Lagno, 2011-08-24 12:58:28]

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc
File base/rand_util.cc (right):

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc#newcode47
base/rand_util.cc:47: DCHECK(n);
On 2011/08/23 17:01:33, Mark Mentovai wrote:
> The DCHECK_GT was a bit more expressive. Why did you change it?

Done.

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.cc#newcode48
base/rand_util.cc:48: // We must discard random results above or equal this
number, as they would
On 2011/08/23 17:01:33, Mark Mentovai wrote:
> Use correct English.

Done.

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.h
File base/rand_util.h (right):

http://codereview.chromium.org/7685053/diff/7001/base/rand_util.h#newcode27
base/rand_util.h:27: BASE_EXPORT uint64 RandGenerator(uint64 n);
On 2011/08/23 17:01:33, Mark Mentovai wrote:
> Why did you need to rename this? It was a little more self-documenting as
“max.”

I consider it being misnomer.
There is long tradition of calling maximum something that can be reached.  So
RandGenerator(max) is expected to generate numbers up to (and including) |max|
That is not the case: maximum of generated numbers for this function is (max-1)
not max.

I changed it to more suitable |range|

[Mark Mentovai, 2011-08-24 14:03:02]

LGTM otherwise

http://codereview.chromium.org/7685053/diff/12003/base/rand_util.cc
File base/rand_util.cc (right):

http://codereview.chromium.org/7685053/diff/12003/base/rand_util.cc#newcode52
base/rand_util.cc:52: uint64 max_acceptable_value = kuint64max / range * range -
1;
Please go back to using std::numeric_limits<uint64>::max() as you had done in
the original change.

[Denis Lagno, 2011-08-24 16:42:44]

http://codereview.chromium.org/7685053/diff/12003/base/rand_util.cc
File base/rand_util.cc (right):

http://codereview.chromium.org/7685053/diff/12003/base/rand_util.cc#newcode52
base/rand_util.cc:52: uint64 max_acceptable_value = kuint64max / range * range -
1;
On 2011/08/24 14:03:03, Mark Mentovai wrote:
> Please go back to using std::numeric_limits<uint64>::max() as you had done in
> the original change.

Done.

[Mark Mentovai, 2011-08-24 16:48:12]

OK. LGTM.

[commit-bot: I haz the power, 2011-08-24 19:58:40]

Change committed as 98098