Issue 7685040: Remove DisableOCSP().

Issue 7685040: Remove DisableOCSP(). (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 4 months ago

Reviewers:
wtc, willchan no longer on Chromium

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, brettw-cc_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove DisableOCSP(). Instead of calling DisableOCSP() all SSL socket used in sandbox should be created with reb_checking_enabled flag set to false. BUG=93273 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97918

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -42 lines)			Patch
M	chrome/renderer/chrome_render_process_observer.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	net/ocsp/nss_ocsp.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/ocsp/nss_ocsp.cc	View		3 chunks	+3 lines, -18 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	net/socket/ssl_server_socket_nss.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/protocol/jingle_stream_connector.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. Thanks! In the CL's commit message, please mention that you set ssl_config.rev_checking_enabled to false ...

9 years, 4 months ago (2011-08-23 01:49:21 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/7685040/diff/1/remoting/protocol/jingle_stream_connector.cc File remoting/protocol/jingle_stream_connector.cc (right): http://codereview.chromium.org/7685040/diff/1/remoting/protocol/jingle_stream_connector.cc#newcode46 remoting/protocol/jingle_stream_connector.cc:46: ssl_config.rev_checking_enabled = false; On 2011/08/23 01:49:21, wtc wrote: > ...

9 years, 4 months ago (2011-08-23 17:34:50 UTC) #3

LGTM!

Expand Messages | Collapse Messages