Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7025)

Unified Diff: chrome/browser/net/ssl_config_service_manager_pref.cc

Issue 7685019: Demote the Use SSL 3.0 and Use TLS 1.0 options from Under The Hood to (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/advanced_options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/ssl_config_service_manager_pref.cc
===================================================================
--- chrome/browser/net/ssl_config_service_manager_pref.cc (revision 98300)
+++ chrome/browser/net/ssl_config_service_manager_pref.cc (working copy)
@@ -8,10 +8,12 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/command_line.h"
#include "chrome/browser/prefs/pref_change_registrar.h"
#include "chrome/browser/prefs/pref_member.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "content/browser/browser_thread.h"
#include "content/common/notification_details.h"
@@ -134,8 +136,6 @@
// The prefs (should only be accessed from UI thread)
BooleanPrefMember rev_checking_enabled_;
- BooleanPrefMember ssl3_enabled_;
- BooleanPrefMember tls1_enabled_;
// The cached list of disabled SSL cipher suites.
std::vector<uint16> disabled_cipher_suites_;
@@ -152,8 +152,6 @@
rev_checking_enabled_.Init(prefs::kCertRevocationCheckingEnabled,
local_state, this);
- ssl3_enabled_.Init(prefs::kSSL3Enabled, local_state, this);
- tls1_enabled_.Init(prefs::kTLS1Enabled, local_state, this);
pref_change_registrar_.Init(local_state);
pref_change_registrar_.Add(prefs::kCipherSuiteBlacklist, this);
@@ -168,10 +166,6 @@
net::SSLConfig default_config;
prefs->RegisterBooleanPref(prefs::kCertRevocationCheckingEnabled,
default_config.rev_checking_enabled);
- prefs->RegisterBooleanPref(prefs::kSSL3Enabled,
- default_config.ssl3_enabled);
- prefs->RegisterBooleanPref(prefs::kTLS1Enabled,
- default_config.tls1_enabled);
prefs->RegisterListPref(prefs::kCipherSuiteBlacklist);
}
@@ -208,8 +202,12 @@
void SSLConfigServiceManagerPref::GetSSLConfigFromPrefs(
net::SSLConfig* config) {
config->rev_checking_enabled = rev_checking_enabled_.GetValue();
- config->ssl3_enabled = ssl3_enabled_.GetValue();
- config->tls1_enabled = tls1_enabled_.GetValue();
+
+ config->ssl3_enabled =
+ !CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableSSL3);
+ config->tls1_enabled =
+ !CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableTLS1);
+
config->disabled_cipher_suites = disabled_cipher_suites_;
SSLConfigServicePref::SetSSLConfigFlags(config);
}
« no previous file with comments | « no previous file | chrome/browser/resources/options/advanced_options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698