Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Side by Side Diff: chrome/browser/ui/webui/options/advanced_options_handler.cc

Issue 7685019: Demote the Use SSL 3.0 and Use TLS 1.0 options from Under The Hood to (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/advanced_options_handler.h" 5 #include "chrome/browser/ui/webui/options/advanced_options_handler.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 #if !defined(OS_CHROMEOS) 87 #if !defined(OS_CHROMEOS)
88 { "proxiesConfigureButton", 88 { "proxiesConfigureButton",
89 IDS_OPTIONS_PROXIES_CONFIGURE_BUTTON }, 89 IDS_OPTIONS_PROXIES_CONFIGURE_BUTTON },
90 #endif 90 #endif
91 { "safeBrowsingEnableProtection", 91 { "safeBrowsingEnableProtection",
92 IDS_OPTIONS_SAFEBROWSING_ENABLEPROTECTION }, 92 IDS_OPTIONS_SAFEBROWSING_ENABLEPROTECTION },
93 { "sslGroupDescription", 93 { "sslGroupDescription",
94 IDS_OPTIONS_SSL_GROUP_DESCRIPTION }, 94 IDS_OPTIONS_SSL_GROUP_DESCRIPTION },
95 { "sslCheckRevocation", 95 { "sslCheckRevocation",
96 IDS_OPTIONS_SSL_CHECKREVOCATION }, 96 IDS_OPTIONS_SSL_CHECKREVOCATION },
97 { "sslUseSSL3",
98 IDS_OPTIONS_SSL_USESSL3 },
99 { "sslUseTLS1",
100 IDS_OPTIONS_SSL_USETLS1 },
101 { "networkPredictionEnabledDescription", 97 { "networkPredictionEnabledDescription",
102 IDS_NETWORK_PREDICTION_ENABLED_DESCRIPTION }, 98 IDS_NETWORK_PREDICTION_ENABLED_DESCRIPTION },
103 { "privacyContentSettingsButton", 99 { "privacyContentSettingsButton",
104 IDS_OPTIONS_PRIVACY_CONTENT_SETTINGS_BUTTON }, 100 IDS_OPTIONS_PRIVACY_CONTENT_SETTINGS_BUTTON },
105 { "privacyClearDataButton", 101 { "privacyClearDataButton",
106 IDS_OPTIONS_PRIVACY_CLEAR_DATA_BUTTON }, 102 IDS_OPTIONS_PRIVACY_CLEAR_DATA_BUTTON },
107 { "linkDoctorPref", 103 { "linkDoctorPref",
108 IDS_OPTIONS_LINKDOCTOR_PREF }, 104 IDS_OPTIONS_LINKDOCTOR_PREF },
109 { "suggestPref", 105 { "suggestPref",
110 IDS_OPTIONS_SUGGEST_PREF }, 106 IDS_OPTIONS_SUGGEST_PREF },
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs(); 225 PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
230 #if !defined(OS_CHROMEOS) 226 #if !defined(OS_CHROMEOS)
231 enable_metrics_recording_.Init(prefs::kMetricsReportingEnabled, 227 enable_metrics_recording_.Init(prefs::kMetricsReportingEnabled,
232 g_browser_process->local_state(), this); 228 g_browser_process->local_state(), this);
233 cloud_print_proxy_email_.Init(prefs::kCloudPrintEmail, prefs, this); 229 cloud_print_proxy_email_.Init(prefs::kCloudPrintEmail, prefs, this);
234 cloud_print_proxy_enabled_.Init(prefs::kCloudPrintProxyEnabled, prefs, this); 230 cloud_print_proxy_enabled_.Init(prefs::kCloudPrintProxyEnabled, prefs, this);
235 #endif 231 #endif
236 232
237 rev_checking_enabled_.Init(prefs::kCertRevocationCheckingEnabled, 233 rev_checking_enabled_.Init(prefs::kCertRevocationCheckingEnabled,
238 g_browser_process->local_state(), this); 234 g_browser_process->local_state(), this);
239 ssl3_enabled_.Init(prefs::kSSL3Enabled, g_browser_process->local_state(),
240 this);
241 tls1_enabled_.Init(prefs::kTLS1Enabled, g_browser_process->local_state(),
242 this);
243 235
244 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 236 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
245 background_mode_enabled_.Init(prefs::kBackgroundModeEnabled, 237 background_mode_enabled_.Init(prefs::kBackgroundModeEnabled,
246 g_browser_process->local_state(), 238 g_browser_process->local_state(),
247 this); 239 this);
248 #endif 240 #endif
249 241
250 default_download_location_.Init(prefs::kDownloadDefaultDirectory, 242 default_download_location_.Init(prefs::kDownloadDefaultDirectory,
251 prefs, this); 243 prefs, this);
252 ask_for_save_location_.Init(prefs::kPromptForDownload, prefs, this); 244 ask_for_save_location_.Init(prefs::kPromptForDownload, prefs, this);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 NewCallback(this, 289 NewCallback(this,
298 &AdvancedOptionsHandler::HandleDisableCloudPrintProxy)); 290 &AdvancedOptionsHandler::HandleDisableCloudPrintProxy));
299 } 291 }
300 web_ui_->RegisterMessageCallback("showNetworkProxySettings", 292 web_ui_->RegisterMessageCallback("showNetworkProxySettings",
301 NewCallback(this, 293 NewCallback(this,
302 &AdvancedOptionsHandler::ShowNetworkProxySettings)); 294 &AdvancedOptionsHandler::ShowNetworkProxySettings));
303 #endif 295 #endif
304 web_ui_->RegisterMessageCallback("checkRevocationCheckboxAction", 296 web_ui_->RegisterMessageCallback("checkRevocationCheckboxAction",
305 NewCallback(this, 297 NewCallback(this,
306 &AdvancedOptionsHandler::HandleCheckRevocationCheckbox)); 298 &AdvancedOptionsHandler::HandleCheckRevocationCheckbox));
307 web_ui_->RegisterMessageCallback("useSSL3CheckboxAction",
308 NewCallback(this,
309 &AdvancedOptionsHandler::HandleUseSSL3Checkbox));
310 web_ui_->RegisterMessageCallback("useTLS1CheckboxAction",
311 NewCallback(this,
312 &AdvancedOptionsHandler::HandleUseTLS1Checkbox));
313 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 299 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
314 web_ui_->RegisterMessageCallback("backgroundModeAction", 300 web_ui_->RegisterMessageCallback("backgroundModeAction",
315 NewCallback(this, 301 NewCallback(this,
316 &AdvancedOptionsHandler::HandleBackgroundModeCheckbox)); 302 &AdvancedOptionsHandler::HandleBackgroundModeCheckbox));
317 #endif 303 #endif
318 } 304 }
319 305
320 void AdvancedOptionsHandler::Observe(int type, 306 void AdvancedOptionsHandler::Observe(int type,
321 const NotificationSource& source, 307 const NotificationSource& source,
322 const NotificationDetails& details) { 308 const NotificationDetails& details) {
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 const ListValue* args) { 402 const ListValue* args) {
417 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args)); 403 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args));
418 bool enabled = checked_str == "true"; 404 bool enabled = checked_str == "true";
419 UserMetrics::RecordAction( 405 UserMetrics::RecordAction(
420 enabled ? 406 enabled ?
421 UserMetricsAction("Options_CheckCertRevocation_Enable") : 407 UserMetricsAction("Options_CheckCertRevocation_Enable") :
422 UserMetricsAction("Options_CheckCertRevocation_Disable")); 408 UserMetricsAction("Options_CheckCertRevocation_Disable"));
423 rev_checking_enabled_.SetValue(enabled); 409 rev_checking_enabled_.SetValue(enabled);
424 } 410 }
425 411
426 void AdvancedOptionsHandler::HandleUseSSL3Checkbox(const ListValue* args) {
427 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args));
428 bool enabled = checked_str == "true";
429 UserMetrics::RecordAction(
430 enabled ?
431 UserMetricsAction("Options_SSL3_Enable") :
432 UserMetricsAction("Options_SSL3_Disable"));
433 ssl3_enabled_.SetValue(enabled);
434 }
435
436 void AdvancedOptionsHandler::HandleUseTLS1Checkbox(const ListValue* args) {
437 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args));
438 bool enabled = checked_str == "true";
439 UserMetrics::RecordAction(
440 enabled ?
441 UserMetricsAction("Options_TLS1_Enable") :
442 UserMetricsAction("Options_TLS1_Disable"));
443 tls1_enabled_.SetValue(enabled);
444 }
445
446 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 412 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
447 void AdvancedOptionsHandler::HandleBackgroundModeCheckbox( 413 void AdvancedOptionsHandler::HandleBackgroundModeCheckbox(
448 const ListValue* args) { 414 const ListValue* args) {
449 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args)); 415 std::string checked_str = UTF16ToUTF8(ExtractStringValue(args));
450 bool enabled = checked_str == "true"; 416 bool enabled = checked_str == "true";
451 UserMetrics::RecordAction(enabled ? 417 UserMetrics::RecordAction(enabled ?
452 UserMetricsAction("Options_BackgroundMode_Enable") : 418 UserMetricsAction("Options_BackgroundMode_Enable") :
453 UserMetricsAction("Options_BackgroundMode_Disable")); 419 UserMetricsAction("Options_BackgroundMode_Disable"));
454 background_mode_enabled_.SetValue(enabled); 420 background_mode_enabled_.SetValue(enabled);
455 } 421 }
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 } 607 }
642 608
643 void AdvancedOptionsHandler::SetupSSLConfigSettings() { 609 void AdvancedOptionsHandler::SetupSSLConfigSettings() {
644 { 610 {
645 base::FundamentalValue checked(rev_checking_enabled_.GetValue()); 611 base::FundamentalValue checked(rev_checking_enabled_.GetValue());
646 base::FundamentalValue disabled(rev_checking_enabled_.IsManaged()); 612 base::FundamentalValue disabled(rev_checking_enabled_.IsManaged());
647 web_ui_->CallJavascriptFunction( 613 web_ui_->CallJavascriptFunction(
648 "options.AdvancedOptions.SetCheckRevocationCheckboxState", checked, 614 "options.AdvancedOptions.SetCheckRevocationCheckboxState", checked,
649 disabled); 615 disabled);
650 } 616 }
651 {
652 base::FundamentalValue checked(ssl3_enabled_.GetValue());
653 base::FundamentalValue disabled(ssl3_enabled_.IsManaged());
654 web_ui_->CallJavascriptFunction(
655 "options.AdvancedOptions.SetUseSSL3CheckboxState", checked, disabled);
656 }
657 {
658 base::FundamentalValue checked(tls1_enabled_.GetValue());
659 base::FundamentalValue disabled(tls1_enabled_.IsManaged());
660 web_ui_->CallJavascriptFunction(
661 "options.AdvancedOptions.SetUseTLS1CheckboxState", checked, disabled);
662 }
663 } 617 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698