Don't call RenderView directly if USE_THREADED_COMPOSITOR is set.

Don't call RenderView directly if USE_THREADED_COMPOSITOR is set.

These calls won't be thread-safe in the new compositor model, and
they shouldn't be needed as the compositor will manage its own
SwapBuffer calls. (Currently WebKit can do it at arbitrary times,
so we need callbacks to keep track).
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97534

[nduca, 2011-08-19 18:25:17]

LGTM

[lain Merrick, 2011-08-19 20:50:13]

Hi James, could you please do an OWNERS review of this CL?

[jamesr, 2011-08-19 21:31:10]

LGTM, although you missed on guard so this won't compile if
WTF_USE_THREADED_COMPOSITING is true.

http://codereview.chromium.org/7685001/diff/5002/content/renderer/gpu/webgrap...
File content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc (right):

http://codereview.chromium.org/7685001/diff/5002/content/renderer/gpu/webgrap...
content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc:41:
web_view_(NULL),
You need to guard this reference to web_view_ as well, don't you?

[lain Merrick, 2011-08-19 21:33:26]

http://codereview.chromium.org/7685001/diff/5002/content/renderer/gpu/webgrap...
File content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc (right):

http://codereview.chromium.org/7685001/diff/5002/content/renderer/gpu/webgrap...
content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc:41:
web_view_(NULL),
On 2011/08/19 21:31:10, jamesr wrote:
> You need to guard this reference to web_view_ as well, don't you?

Oops, good catch. I tried compiling with use_threaded_compositor=1, but I
thought the error I hit was in another file. I'll check again more carefully.