Issue 7677034: Update sync protos to use the new shared protoc gyp rules

Issue 7677034: Update sync protos to use the new shared protoc gyp rules (Closed)

Created:
9 years, 4 months ago by Evan Martin

Modified:
9 years, 4 months ago

Reviewers:
TVL, akalin

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, cbentzel+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update sync protos to use the new shared protoc gyp rules Just a refactoring. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97484

Patch Set 1 #

Total comments: 3

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -92 lines)			Patch
M	build/protoc.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/protocol/sync_proto.gyp	View	2 chunks	+4 lines, -76 lines	2 comments	Download
M	chrome/chrome.gyp	View	3 chunks	+9 lines, -9 lines	1 comment	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	net/net.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

akalin

http://codereview.chromium.org/7677034/diff/1/chrome/browser/sync/protocol/sync_proto.gyp File chrome/browser/sync/protocol/sync_proto.gyp (left): http://codereview.chromium.org/7677034/diff/1/chrome/browser/sync/protocol/sync_proto.gyp#oldcode104 chrome/browser/sync/protocol/sync_proto.gyp:104: 'hard_dependency': 1, pretty sure we still need a hard ...

9 years, 4 months ago (2011-08-18 22:28:17 UTC) #2

Evan Martin

9 years, 4 months ago (2011-08-18 22:36:17 UTC) #3

TVL

9 years, 4 months ago (2011-08-19 13:05:21 UTC) #5

Part of me wonders if sync_proto should become a .gypi to remove another
target/project from the tree.

LGTM

http://codereview.chromium.org/7677034/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

http://codereview.chromium.org/7677034/diff/1/chrome/chrome.gyp#newcode557
chrome/chrome.gyp:557: 'hard_dependency': 1,
This seems like an odd ripple.  But maybe I just need more coffee before it
makes sense.

Expand Messages | Collapse Messages