Try to reduce the flankness of the PPAPI UI tests.

chrome/test/ui/ppapi_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/test/test_timeouts.h"
 #include "build/build_config.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/automation/tab_proxy.h"
@@ skipping 72 matching lines @@
     RunTestURL(
         test_server.GetURL("files/test_case.html?testcase=" + test_case));
   }
 
  private:
   void RunTestURL(const GURL& test_url) {
     scoped_refptr<TabProxy> tab(GetActiveTab());
     ASSERT_TRUE(tab.get());
     ASSERT_TRUE(tab->NavigateToURL(test_url));
 
-    // First wait for the "starting" signal. This cookie is set at the start
-    // of every test. Waiting for this separately allows us to avoid a single
-    // long timeout. Instead, we can have two timeouts which allow startup +
-    // test execution time to take a while on a loaded computer, while also
-    // making sure we're making forward progress.
-    std::string startup_cookie =
-        WaitUntilCookieNonEmpty(tab.get(), test_url,
-            "STARTUP_COOKIE", TestTimeouts::action_max_timeout_ms());
+    // See comment above TestingInstance in the ppapi test plugin. Basically

[polina, 2011/08/22 23:53:58]

a file path would be useful here

+    // it sets a series of numbered cookies. The value of "..." means it's
+    // still working and we should continue to wait, any other value indicates
+    // completion (in this case it will start with "PASS" or "FAIL". This
+    // keeps us from timing out on cookie waits for long tests.

[polina, 2011/08/22 23:53:58]

missing closing ")"

+    int progress_number = 0;
+    std::string progress;
+    while (true) {

[Paweł Hajdan Jr., 2011/08/18 22:45:13]

NOOOOOOO! If you need a loop, you're doing it wrong. Please wait for an event
instead. Let me know if I can help with figuring out the right design. Feel free
to ping my by IM/irc/e-mail/at my desk.

[Paweł Hajdan Jr., 2011/08/18 22:47:20]

Ooops, please ignore my earlier comment. It's not a polling loop.

+      std::string cookie_name = StringPrintf("PPAPI_PROGRESS_%d",

[polina, 2011/08/22 23:53:58]

Is it not an option to share "PPAPI_PROGRESS", "...", etc constants with the
test code?

[brettw, 2011/08/24 16:42:17]

Unfortunately, there's no code in common between these two projects.

+                                             progress_number);
+      progress = WaitUntilCookieNonEmpty(tab.get(), test_url,
+            cookie_name.c_str(), TestTimeouts::large_test_timeout_ms());
+      if (progress != "...")
+        break;
+      progress_number++;
+    }
 
-    // If this fails, the plugin couldn't be loaded in the given amount of
-    // time. This may mean the plugin was not found or possibly the system
-    // can't load it due to missing symbols, etc.
-    ASSERT_STREQ("STARTED", startup_cookie.c_str())
-        << "Plugin couldn't be loaded. Make sure the PPAPI test plugin is "
-        << "built, in the right place, and doesn't have any missing symbols.";
+    if (progress_number == 0) {
+      // Failing the first time probably means the plugin wasn't loaded.
+      ASSERT_FALSE(progress.empty())
+          << "Plugin couldn't be loaded. Make sure the PPAPI test plugin is "
+          << "built, in the right place, and doesn't have any missing symbols.";
+    } else {
+      ASSERT_FALSE(progress.empty()) << "Test timed out.";
+    }
 
-    std::string escaped_value =
-        WaitUntilCookieNonEmpty(tab.get(), test_url,
-            "COMPLETION_COOKIE", TestTimeouts::large_test_timeout_ms());
-    EXPECT_STREQ("PASS", escaped_value.c_str());
+    EXPECT_STREQ("PASS", progress.c_str());
   }
 };
 
 // Variant of PPAPITest that runs plugins out-of-process to test proxy
 // codepaths.
 class OutOfProcessPPAPITest : public PPAPITest {
  public:
   OutOfProcessPPAPITest() {
     // Run PPAPI out-of-process to exercise proxy implementations.
     launch_arguments_.AppendSwitch(switches::kPpapiOutOfProcess);
@@ skipping 142 matching lines @@
 TEST_F(OutOfProcessPPAPITest, FAILS_Transport) {
   RunTestViaHTTP("Transport");
 }
 #endif // ENABLE_P2P_APIS
 
 TEST_PPAPI_IN_PROCESS(UMA)
 // There is no proxy.
 TEST_F(OutOfProcessPPAPITest, FAILS_UMA) {
   RunTest("UMA");
 }