Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 7677019: Fix infinite recursion in find_depot_tools (Closed)

Created:
9 years, 4 months ago by clee
Modified:
9 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org, gavinp
Visibility:
Public.

Description

Added end condition when going to parent directory doesn't change the path BUG=93285 TEST=script exits when depot_tools is not on machine Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/find_depot_tools.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
clee
Unfortunately, os.path.dirname() doesn't strip the trailing slash if it's at root.
9 years, 4 months ago (2011-08-18 14:51:31 UTC) #1
M-A Ruel
lgtm, I need to fix it in the 56 other copies of this script.
9 years, 4 months ago (2011-08-18 14:54:54 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-18 18:52:20 UTC) #3
Change committed as 97346

Powered by Google App Engine
This is Rietveld 408576698