Issue 7677011: Supports additional Indic languages on the language setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7677011: Supports additional Indic languages on the language setting. (Closed)

Created:
9 years, 4 months ago by yoshiki

Modified:
9 years, 3 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Supports additional Indic languages on the language setting. The languages to add are following. - Bengali (bn) - Gujarati (gu) - Kannada (kn) - Malayalam (ml) - Marathi (mr) - Tamil (ta) - Telugu (te) In addition to this CL, we have to rebuild ICU data file (icudt46l_dat.S) to include data for new languages. It will be added on another CL. BUG=chromium-os:18755 TEST=manual on chromeos-chrome in Linux, using linux/icudt46l_dat.S Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98813

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_util.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

On 2011/08/22 17:43:37, Jungshik Shin wrote: > LGTM Just wondering where's the line for Hindi ...

9 years, 4 months ago (2011-08-22 17:57:37 UTC) #3

yoshiki

9 years, 3 months ago (2011-08-30 15:07:21 UTC) #4

Sorry, I missed out on your LGTM. Committed it without "kn" and "te".

> Just wondering where's the line for Hindi (which we already supports).  I
don't
> see the line for Hindi around the change you're making.

Hindi and other supported language are on the list of input methods, not on this
list. This list has only the languages which have no specific input method and
use "US keyboard" instead.

On 2011/08/22 17:57:37, Jungshik Shin wrote:
> On 2011/08/22 17:43:37, Jungshik Shin wrote:
> > LGTM
> 
> Just wondering where's the line for Hindi (which we already supports).  I
don't
> see the line for Hindi around the change you're making.

Expand Messages | Collapse Messages