Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: libvpx.gyp

Issue 7677008: Fix ARM and add -fvisibility=hidden back to libvpx since its linked statically. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/libvpx/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libvpx.gyp
===================================================================
--- libvpx.gyp (revision 97071)
+++ libvpx.gyp (working copy)
@@ -148,19 +148,6 @@
'source/libvpx',
],
},
- 'cflags!': [
- # Ensure the symbols are exported since this library gets wrapped by
- # ffmpeg's shared lib. When we stop doing that (crbug.com/70687)
- # this can go away.
- '-fvisibility=hidden',
- ],
- 'conditions': [
- [ 'OS=="mac"', {
- 'xcode_settings': {
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # No -fvisibility=hidden
- },
- }],
- ],
'rules': [
{
'rule_name': 'assemble',
@@ -392,16 +379,15 @@
# generated to.
'-Wa,-I,third_party/libvpx/source/config/<(OS)/<(target_arch_full)',
],
- 'cflags!': [
- # Ensure the symbols are exported since this library gets wrapped by
- # ffmpeg's shared lib. When we stop doing that (crbug.com/70687)
- # this can go away.
- '-fvisibility=hidden',
- ],
'include_dirs': [
'source/config/<(OS)/<(target_arch_full)',
'source/libvpx',
],
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ 'source/libvpx',
+ ],
+ },
'sources': [
'<@(libvpx_generic_sources)',
# Generated by ./source/configure and checked in.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698