Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 7677008: Fix ARM and add -fvisibility=hidden back to libvpx since its linked statically. (Closed)

Created:
9 years, 4 months ago by scherkus (not reviewing)
Modified:
9 years, 4 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Fix ARM and add -fvisibility=hidden back to libvpx since its linked statically. BUG=50811 TEST=build on ARM, check binaries with nm Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M libvpx.gyp View 2 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
9 years, 4 months ago (2011-08-18 03:51:32 UTC) #1
Alpha Left Google
9 years, 4 months ago (2011-08-18 10:14:34 UTC) #2
On 2011/08/18 03:51:32, scherkus wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698