Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 7677001: Some fixes to panel support on Windows: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_view.cc
===================================================================
--- chrome/browser/ui/panels/panel_browser_view.cc (revision 97031)
+++ chrome/browser/ui/panels/panel_browser_view.cc (working copy)
@@ -17,11 +17,8 @@
namespace {
// This value is experimental and subjective.
-const int kSetBoundsAnimationMs = 200;
+const int kSetBoundsAnimationMs = 180;
-// The panel can be fully minimized to 3-pixel lines.
-const int kFullyMinimizedHeight = 3;
-
// Delay before click-to-minimize is allowed after the attention has been
// cleared.
const base::TimeDelta kSuspendMinimizeOnClickIntervalMs =
@@ -196,7 +193,7 @@
height = GetFrameView()->NonClientTopBorderHeight();
break;
case Panel::MINIMIZED:
- height = kFullyMinimizedHeight;
+ height = PanelBrowserFrameView::MinimizedPanelHeight();
// Start the mouse watcher so that we can bring up the minimized panels.
// TODO(jianli): Need to support mouse watching in ChromeOS.
@@ -356,7 +353,9 @@
}
bool PanelBrowserView::OnTitlebarMouseCaptureLost() {
- return EndDragging(true);
+ if (mouse_dragging_)
+ return EndDragging(true);
+ return true;
}
bool PanelBrowserView::EndDragging(bool cancelled) {

Powered by Google App Engine
This is Rietveld 408576698