[ntp4] Prevent the page switcher from overlapping the bookmarks-page title header.

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 535 matching lines @@
 
     var pageSwitcherLeft = isRTL() ? pageSwitcherEnd : pageSwitcherStart;
     var pageSwitcherRight = isRTL() ? pageSwitcherStart : pageSwitcherEnd;
     var scrollbarWidth = page.scrollbarWidth;
     pageSwitcherLeft.style.width =
         (page.sideMargin + 13) + 'px';
     pageSwitcherLeft.style.left = '0';
     pageSwitcherRight.style.width =
         (page.sideMargin - scrollbarWidth + 13) + 'px';
     pageSwitcherRight.style.right = scrollbarWidth + 'px';
+    pageSwitcherLeft.style.top = pageSwitcherRight.style.top =
+        page.querySelector('.tile-page-content').offsetTop + 'px';

[Evan Stade, 2011/08/17 21:04:29]

I think you should set an equal margin on the bottom so the < doesn't jump
around

[csilv, 2011/08/17 23:05:58]

Done.  The padding-bottom is what works for this.

   }
 
   /**
    * Returns the index of the given page.
    * @param {AppsPage} page The AppsPage for we wish to find.
    * @return {number} The index of |page|, or -1 if it is not here.
    */
   function getAppsPageIndex(page) {
     return Array.prototype.indexOf.call(appsPages, page);
   }
@@ skipping 172 matching lines @@
 // TODO(estade): update the content handlers to use ntp namespace instead of
 // making these global.
 var assert = ntp4.assert;
 var getAppsCallback = ntp4.getAppsCallback;
 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
 var themeChanged = ntp4.themeChanged;
 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
 var setMostVisitedPages = ntp4.setMostVisitedPages;
 
 document.addEventListener('DOMContentLoaded', ntp4.initialize);