Issue 7674001: [ntp4] Prevent the page switcher from overlapping the bookmarks-page title header.

Issue 7674001: [ntp4] Prevent the page switcher from overlapping the bookmarks-page title header. (Closed)

Created:
9 years, 4 months ago by csilv

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Prevent the page switcher from overlapping the bookmarks-page title header. BUG=92921, 93347 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97354

Patch Set 5 : Final review change. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/resources/ntp4/new_tab.css	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/ntp4/new_tab.js	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/7674001/diff/2001/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): http://codereview.chromium.org/7674001/diff/2001/chrome/browser/resources/ntp4/new_tab.js#newcode557 chrome/browser/resources/ntp4/new_tab.js:557: page.querySelector('.tile-page-content').offsetTop + 'px'; I think you should set an ...

9 years, 4 months ago (2011-08-17 21:04:28 UTC) #2

csilv

9 years, 4 months ago (2011-08-17 23:05:58 UTC) #3

Evan Stade

http://codereview.chromium.org/7674001/diff/5002/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): http://codereview.chromium.org/7674001/diff/5002/chrome/browser/resources/ntp4/new_tab.js#newcode556 chrome/browser/resources/ntp4/new_tab.js:556: pageSwitcherLeft.style.top = pageSwitcherRight.style.top = I'm not sure but I ...

9 years, 4 months ago (2011-08-18 00:40:01 UTC) #4

csilv

9 years, 4 months ago (2011-08-18 18:10:35 UTC) #5

Evan Stade

lgtm http://codereview.chromium.org/7674001/diff/3003/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): http://codereview.chromium.org/7674001/diff/3003/chrome/browser/resources/ntp4/new_tab.js#newcode560 chrome/browser/resources/ntp4/new_tab.js:560: pageSwitcherLeft.style.top = offsetTop + 'px'; I would put ...

9 years, 4 months ago (2011-08-18 20:29:47 UTC) #6

csilv

9 years, 4 months ago (2011-08-18 20:41:38 UTC) #7

http://codereview.chromium.org/7674001/diff/3003/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7674001/diff/3003/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:560: pageSwitcherLeft.style.top =
offsetTop + 'px';
On 2011/08/18 20:29:47, Evan Stade wrote:
> I would put the + 'px' in offsetTop as well

Done.

Expand Messages | Collapse Messages