Issue 7672014: Bugs in x64 ICs introduced by array length refactor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7672014: Bugs in x64 ICs introduced by array length refactor. (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Bugs in x64 ICs introduced by array length refactor. BUG=chromium:93044 TEST=external-array.js Committed: http://code.google.com/p/v8/source/detail?r=8951

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	src/x64/stub-cache-x64.cc	View		8 chunks	+30 lines, -30 lines	0 comments	Download

Total messages: 2 (0 generated)

Rico

9 years, 4 months ago (2011-08-17 09:00:18 UTC) #2

LGTM, I don't see anyting in external-array.js that test this (or maybe this
file got left out of the cl?), could we add a regression test?