Support for promo in ntp4.

Support for promo in ntp4.

support for configurable timeouts in showNotification.
showNotification for serverpromo if the string exists, for 60 sec.
chrome.send('closePromo') on user dismissing promo.
support for html fragments in promo_line + use parseHtmlSubset to guard against xss injection.

BUG=93201
TEST=Setup user Preferences with valid promo_start/promo_end/promo_build. Create promo_line with embedded href. Promo should show up on new tab page upon launch. Should fade after 1 min if not interacted with. Closing it should result in it not appearing any more.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97958

[achuithb, 2011-08-18 18:24:19]

Please review. Thanks!

[Miranda Callahan, 2011-08-19 08:16:01]

+arv

On 2011/08/18 18:24:19, achuith.bhandarkar wrote:
> Please review. Thanks!

I am adding arv to this review, because he wrote a function to parse the HTML of
the promo very carefully before adding it to the NTP, and I'm afraid that this
has gotten lost in the shuffle along the way. The change looks good to me, but I
want to make sure he gives his blessing before this goes in...

[jstritar, 2011-08-19 14:59:34]

On 2011/08/19 08:16:01, Miranda Callahan wrote:
> +arv
> 
> On 2011/08/18 18:24:19, achuith.bhandarkar wrote:
> > Please review. Thanks!
> 
> I am adding arv to this review, because he wrote a function to parse the HTML
of
> the promo very carefully before adding it to the NTP, and I'm afraid that this
> has gotten lost in the shuffle along the way. The change looks good to me, but
I
> want to make sure he gives his blessing before this goes in...

Yeah, I think that needs to be wrapped with parseHtmlSubset.

http://codesearch.google.com/codesearch#search&q=parseHtmlSubset&exact_packag...

[achuithb, 2011-08-19 20:19:52]

Thanks for pointing me to parseHtmlSubset. I've incorporated this function into
ntp4/new_tab.js. In my testing, the code works correctly for both text, and html
fragments containing anchor links. PTAL. Thanks!

[Evan Stade, 2011-08-19 20:43:23]

http://codereview.chromium.org/7672012/diff/11001/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7672012/diff/11001/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/new_tab.js:659: if (typeof text == 'string') {
name of text param and documentation needs updating

[achuithb, 2011-08-19 21:30:28]

Thanks.

http://codereview.chromium.org/7672012/diff/11001/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7672012/diff/11001/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/new_tab.js:659: if (typeof text == 'string') {
On 2011/08/19 20:43:23, Evan Stade wrote:
> name of text param and documentation needs updating

Done.

[Evan Stade, 2011-08-19 22:38:25]

lgtm

[Miranda Callahan, 2011-08-20 07:25:38]

On 2011/08/19 22:38:25, Evan Stade wrote:
> lgtm

With estade's review and the addition of parseHtmlSubset, LGTM -- no need to
wait for arv. Thanks!

[jstritar, 2011-08-22 17:14:17]

LGTM

[arv (Not doing code reviews), 2011-08-22 17:47:23]

LGTM