Count-up/down the dirty count in the usage cache at FileSystemOperation, not at QuotaFU.

webkit/fileapi/quota_file_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/quota_file_util.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_operation_context.h"
 #include "webkit/fileapi/file_system_path_manager.h"
 #include "webkit/fileapi/file_system_quota_util.h"
 #include "webkit/quota/quota_manager.h"
 
 using quota::QuotaManagerProxy;
 
 namespace fileapi {
 
 const int64 QuotaFileUtil::kNoLimit = kint64max;
 
 // See the comment in the header file as for these constants.
 const int64 QuotaFileUtil::kFilePathCostPerChar = 2;
 const int64 QuotaFileUtil::kFilePathCostPerFile = 146;
 
 namespace {
 
 // A helper class to hook quota_util() methods before and after modifications.
 class ScopedOriginUpdateHelper {

[ericu, 2011/08/19 04:12:59]

Does this class now not actually do anything "scoped"?

[Dai Mikurube (NOT FULLTIME), 2011/08/19 10:21:10]

Agreed.  I'll fix it in the next patch.

  public:
   explicit ScopedOriginUpdateHelper(
       FileSystemOperationContext* operation_context,
       const GURL& origin_url,
       FileSystemType type)
       : operation_context_(operation_context),
         origin_url_(origin_url),
         type_(type) {
     DCHECK(operation_context_);
     DCHECK(operation_context_->file_system_context());
     DCHECK(type != kFileSystemTypeUnknown);
     quota_util_ =
         operation_context_->file_system_context()->GetQuotaUtil(type_);
     quota_manager_proxy_ =
         operation_context_->file_system_context()->quota_manager_proxy();
-    if (quota_util_)
-      quota_util_->StartUpdateOriginOnFileThread(origin_url_, type_);
   }
 
   ~ScopedOriginUpdateHelper() {
-    if (quota_util_)
-      quota_util_->EndUpdateOriginOnFileThread(origin_url_, type_);
   }
 
   void NotifyUpdate(int64 growth) {
     if (operation_context_->allowed_bytes_growth() != QuotaFileUtil::kNoLimit)
       operation_context_->set_allowed_bytes_growth(
           operation_context_->allowed_bytes_growth() - growth);
     if (quota_util_)
       quota_util_->UpdateOriginUsageOnFileThread(
           quota_manager_proxy_, origin_url_, type_, growth);
   }
@@ skipping 286 matching lines @@
   }
   *growth = src_file_info.size - dest_file_info.size + dest_file_path_cost;
   if (allowed_bytes_growth != QuotaFileUtil::kNoLimit &&
       *growth > allowed_bytes_growth)
     return false;
 
   return true;
 }
 
 }  // namespace fileapi