Issue 7670073: ntp4: disable animations for pages that are off screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7670073: ntp4: disable animations for pages that are off screen (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, arv (Not doing code reviews)

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ntp4: disable animations for pages that are off screen also disable all animations during startup (i.e. before the first getAppsCallback call) BUG=92989 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97739

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	chrome/browser/resources/ntp4/card_slider.js	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Stade

the way I determined that this makes a difference was to rapidly resize the browser ...

9 years, 4 months ago (2011-08-18 21:06:09 UTC) #1

arv (Not doing code reviews)

LGTM I wonder if it would be worth only populating the selected card at startup ...

9 years, 4 months ago (2011-08-22 17:57:50 UTC) #2

Change committed as 97739