Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7670045: Revert 97219 - Added Header and Footer support in Linux, Windows and Mac for Skia (Closed)

Created:
9 years, 4 months ago by Aayush Kumar
Modified:
9 years, 4 months ago
Reviewers:
Aayush Kumar
CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 97219 - Added Header and Footer support in Linux, Windows and Mac for Skia BUG=67514 TEST= In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed. Review URL: http://codereview.chromium.org/7348010 TBR=aayushkumar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -738 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/print_preview/header_footer_settings.html View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/print_preview/header_footer_settings.js View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/renderer/mock_printer.h View 2 chunks +0 lines, -58 lines 0 comments Download
M chrome/renderer/mock_printer.cc View 8 chunks +4 lines, -88 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 5 chunks +1 line, -165 lines 0 comments Download
M chrome/renderer/print_web_view_helper_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/renderer/print_web_view_helper_mac.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M printing/print_job_constants.h View 2 chunks +0 lines, -22 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M printing/print_settings.h View 2 chunks +0 lines, -10 lines 0 comments Download
D printing/print_settings_initializer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D printing/print_settings_initializer.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/printing_context.h View 1 chunk +4 lines, -10 lines 0 comments Download
M printing/printing_context.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M printing/printing_context_cairo.h View 1 chunk +2 lines, -3 lines 0 comments Download
M printing/printing_context_cairo.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_mac.h View 1 chunk +2 lines, -3 lines 0 comments Download
M printing/printing_context_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.h View 1 chunk +2 lines, -3 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/units.h View 1 chunk +0 lines, -7 lines 0 comments Download
M printing/units.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 chunk +1 line, -5 lines 0 comments Download
M skia/ext/vector_platform_device_skia.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aayush Kumar
9 years, 4 months ago (2011-08-17 22:24:44 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698