Issue 7670044: Try to catch dlls that crash the plugin process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7670044: Try to catch dlls that crash the plugin process. (Closed)

Created:
9 years, 4 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 4 months ago

Reviewers:
jam, commit-bot: I haz the power, rvargas (doing something else)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Try to catch dlls that crash the plugin process. - With a specific, forced dll eviction policy. Part of the code yellow BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97732

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -17 lines)			Patch
	M	content/common/sandbox_policy.cc	View	1 2	8 chunks	+33 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

LGTM http://codereview.chromium.org/7670044/diff/1/content/common/sandbox_policy.cc File content/common/sandbox_policy.cc (right): http://codereview.chromium.org/7670044/diff/1/content/common/sandbox_policy.cc#newcode164 content/common/sandbox_policy.cc:164: // if |check_in_browser| is true we only add ...

9 years, 4 months ago (2011-08-17 22:12:38 UTC) #2

commit-bot: I haz the power

Presubmit check for 7670044-3002 failed and returned exit status 1. Running presubmit commit checks ...

9 years, 4 months ago (2011-08-17 22:43:31 UTC) #3

Change committed as 97732

Expand Messages | Collapse Messages