chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc - Issue 7670041: Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

Issue 7670041: Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix spelling error in comment. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browser_resources.grd ('K') | « chrome/browser/ui/cocoa/hung_renderer_controller.mm ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

index a27505bab0e6ac7a80f099ccc0419ba6023201e9..79fc82f2b799ab3d9455a954f1154d3354b83a25 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

@@ -308,25 +308,17 @@ void BookmarkBubbleGtk::ShowEditor() {

// Commit any edits now.

ApplyEdits();

-#if !defined(WEBUI_DIALOGS)

// Closing might delete us, so we'll cache what we need on the stack.

Profile* profile = profile_;

GtkWindow* toplevel = GTK_WINDOW(gtk_widget_get_toplevel(anchor_));

-#endif

// Close the bubble, deleting the C++ objects, etc.

bubble_->Close();

if (node) {

-#if defined(WEBUI_DIALOGS)

- Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);

- DCHECK(browser);

- browser->OpenBookmarkManagerEditNode(node->id());

-#else

- BookmarkEditor::Show(toplevel, profile, NULL,

- BookmarkEditor::EditDetails(node),

+ BookmarkEditor::Show(toplevel, profile,

+ BookmarkEditor::EditDetails::EditNode(node),

BookmarkEditor::SHOW_TREE);

-#endif

}