chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 7670041: Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 7670041: Add --use-more-webui runtime flag to toggle WebUI replacements for native dialogs. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Merge with trunk and fix hung renderer dialog close. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm ('k') | chrome/browser/ui/cocoa/hung_renderer_controller.mm » ('j') | chrome/browser/ui/webui/hung_renderer_dialog.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 6444bbce94fb7c45801a7a0a15062afe12f7b5b8..6927119b9edc2a9f6c8d0c44cd1a6b24a5ace0c7 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1634,10 +1634,6 @@ enum {

if (responds) {

const BookmarkNode* node = [sender node];

if (node) {

-#if defined(WEBUI_DIALOGS)

- DCHECK(browser_);

- browser_->OpenBookmarkManagerEditNode(node->id());

-#else

// A BookmarkEditorController is a sheet that owns itself, and

// deallocates itself when closed.

[[[BookmarkEditorController alloc]

@@ -1647,7 +1643,6 @@ enum {

node:node

configuration:BookmarkEditor::SHOW_TREE]

runAsModalSheet];

-#endif

}