Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2569)

Unified Diff: chrome/chrome_exe.gypi

Issue 7670031: restore OutputFile for chrome.exe, do moving hardlink on dll instead (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: use initial instead of incremental to coexist with syzygy flag Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 31a9077d4f5fe13f71a0d2f59f5fad4fb8bf19b5..83b6e98b91db722a7707edb37c9331c8e589cbdd 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -451,20 +451,6 @@
},
},
}],
-
- # Linking to $(IntDir) and then hard-linking back to $(OutDir) is a
- # workaround to avoid having the .ilk files for chrome.dll and
- # chrome.exe conflicting. See http://crbug.com/92528 for background.
- # Only done on 2008 currently because msvs_postbuild isn't implemented
- # on 2010 yet, and this hack may not be required there anyway.
- ['OS=="win" and MSVS_VERSION=="2008"', {
- 'msvs_settings': {
- 'VCLinkerTool': {
- 'OutputFile': '$(IntDir)\\chrome.exe',
- },
- },
- 'msvs_postbuild': 'tools\\build\\win\\hardlink_failsafe.bat $(IntDir)\\chrome.exe $(OutDir)\\chrome.exe'
- }],
],
},
],
« no previous file with comments | « chrome/chrome_dll.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698