Issue 7670023: Fix GC unsafe place in JSProxy::DeletePropertyWithHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7670023: Fix GC unsafe place in JSProxy::DeletePropertyWithHandler. (Closed)

Created:
9 years, 4 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 4 months ago

Reviewers:
wingo, Vitaly Repeshko, rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix GC unsafe place in JSProxy::DeletePropertyWithHandler. Committed: http://code.google.com/p/v8/source/detail?r=8952

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wingo

Out of curiousity, what was the issue? I assume that the call could have triggered ...

9 years, 4 months ago (2011-08-17 09:56:58 UTC) #3

Vitaly Repeshko

9 years, 4 months ago (2011-08-17 12:27:39 UTC) #4

http://codereview.chromium.org/7670023/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7670023/diff/1/src/objects.cc#newcode2322
src/objects.cc:2322: bool_result == isolate->heap()->false_value()) {
Whoa, nice catch!

Expand Messages | Collapse Messages