Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 7670019: Adding native client toolchain download to all chrome checkouts with nacl. (Closed)

Created:
9 years, 4 months ago by bradn
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding native client toolchain download to all chrome checkouts with nacl. This will eventually allow ppapi_proxy + irt to be built along with chrome, allow repository migration. Step2 of ppapi repo migration. BUG=None TEST=None R=noelallen@google.com,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97242 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97260

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M DEPS View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
A build/download_nacl_toolchains.py View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
9 years, 4 months ago (2011-08-17 01:20:33 UTC) #1
noelallen_use_chromium
LGTM. Just a couple nits. http://codereview.chromium.org/7670019/diff/1003/build/download_nacl_toolchains.py File build/download_nacl_toolchains.py (right): http://codereview.chromium.org/7670019/diff/1003/build/download_nacl_toolchains.py#newcode13 build/download_nacl_toolchains.py:13: script_dir = os.path.dirname(os.path.abspath(__file__)) Std ...
9 years, 4 months ago (2011-08-17 01:39:45 UTC) #2
brettw
LGTM
9 years, 4 months ago (2011-08-17 02:20:16 UTC) #3
bradn
http://codereview.chromium.org/7670019/diff/1003/build/download_nacl_toolchains.py File build/download_nacl_toolchains.py (right): http://codereview.chromium.org/7670019/diff/1003/build/download_nacl_toolchains.py#newcode13 build/download_nacl_toolchains.py:13: script_dir = os.path.dirname(os.path.abspath(__file__)) On 2011/08/17 01:39:45, noelallen wrote: > ...
9 years, 4 months ago (2011-08-17 02:26:25 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-18 00:03:18 UTC) #5
Change committed as 97242

Powered by Google App Engine
This is Rietveld 408576698