Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 7670014: [ChromeOS] Fix a problem that Gaia shows up on every bad auth. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[ChromeOS] Fix a problem that Gaia shows up on every bad auth. Gaia should only show up after 3 bad auth attempts. BUG=chromium-os:19248 TEST=Verify fix for chromium-os:19248. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xiyuan
reset is called prior showError and Gaia screen should only show up if it should ...
9 years, 4 months ago (2011-08-16 23:39:22 UTC) #1
achuithb
LGTM
9 years, 4 months ago (2011-08-16 23:41:12 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-17 05:25:13 UTC) #3
Change committed as 97099

Powered by Google App Engine
This is Rietveld 408576698